Simplify auth to SSO with optional demo mode#69
Merged
initstring merged 3 commits intomainfrom Jan 17, 2026
Merged
Conversation
Owner
Author
|
All checks/tests are passing. Manual testing - demo mode works as expected. No passkeys artifacts visible in settings. @codex please review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
Author
|
Note: this will be a breaking change and require a major version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ENABLE_DEMO_MODE, and removed the one‑time login link code and helper (src/server/auth/login-link.tsand related constants and script).ENABLE_DEMO_MODEto the env schema and wiring (src/env.ts,.env.example,deploy/docker/.env.example, anddeploy/docker/docker-compose.yml) and made UI sign‑in pages honor the toggle (src/app/(public-routes)/auth/signin/page.tsx,src/features/shared/auth/sign-in-page.tsx).src/server/api/routers/users.ts,src/server/services/userService.ts,src/features/settings/components/users-tab.tsx,src/app/(protected-routes)/account/page.tsx, andsrc/features/shared/users/user-validators.ts).democredentials provider when enabled, removed passkey experimental enablement and login‑link provider, and adjusted sign‑in callback logic to enforce provider rules (src/server/auth/config.ts).Testing
npm run testandnpm run checkwere not run here.npm uninstall/npm install) were performed to align package.json changes; no test failures were observed because tests were not executed.npm run checkandnpm run testafter pulling these changes and before merging to validate type/lint/test coverage in CI.Codex Task